From 31d73fc742863ecda51c834ad81cd15692c52b55 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer@bsz-bw.de>
Date: Wed, 27 Dec 2023 17:52:55 +0000
Subject: [PATCH] Bug 28012: (QA follow-up) Use form validation for numbering
 patterns

Activates standard validation and error messages. Converts from
pattern check to digits class for "display order" field.

To test:
* Compare error message when leaving required fields empty
* Compare error message when entering wrong/false data in display order

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit f816027ea15278c7ed4b738915e963e22ee5c2e6)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 452ab27397cf3023aab53b12904182871fa1f490)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../prog/en/modules/serials/subscription-numberpatterns.tt   | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
index ca1f27c74f..77e7da16ef 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
@@ -59,7 +59,7 @@
             [% END %]
           [% END %]
 
-          <form action="/cgi-bin/koha/serials/subscription-numberpatterns.pl" method="post">
+          <form action="/cgi-bin/koha/serials/subscription-numberpatterns.pl" method="post" class="validated">
             [% IF (new) %]
               <input type="hidden" name="op" value="savenew" />
             [% ELSE %]
@@ -84,8 +84,7 @@
                 </li>
                 <li>
                   <label for="displayorder">Display order:</label>
-                  <input type="text" inputmode="numeric" pattern="\d*" id="displayorder" name="displayorder" value="[% displayorder | html %]" />
-                  <div class="hint">Only numeric characters are allowed</div>
+                  <input type="text" inputmode="numeric" class="digits" id="displayorder" name="displayorder" value="[% displayorder | html %]" />
                 </li>
               </ol>
               <table>
-- 
2.20.1