From 3389e03035dc6b187045e279dc34916b005afbfb Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 5 Jun 2015 07:50:26 -0400 Subject: [PATCH] Bug 14337: AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability AllowRenewalIfOtherItemsAvailable checks C4::Reserves::IsAvailableForItemLevelRequest to see if the item is holdable, which catches not for loan values less than 0 ( i.e. holdable, but not circ-able ). However, since this feature is about actually checking out items to patrons, we should not count *any* not for loan items when deciding if the available items will satisfy all current holds. Test Plan: 1) Enable AllowRenewalIfOtherItemsAvailable 2) Create a record with two items 3) Check out one item to a patron 4) Ensure the item is renewable 5) Place a hold on the record 6) The item should now be non-renewable 7) Add a second item to the record, but with a not for loan value < 0 8) Note the checkout is still renewable 9) Apply this patch 10) Note the checkout is now non-renewable Works ok. Signed-off-by: Amit Gupta Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi --- C4/Circulation.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 7813e3305f..5177203ab9 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2693,6 +2693,7 @@ sub CanBookBeRenewed { { biblionumber => $resrec->{biblionumber}, onloan => undef, + notforloan => 0, -not => { itemnumber => $itemnumber } }, { columns => 'itemnumber' } -- 2.39.5