From 537132da7bec95958cc548a915733c1ff76cce14 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 21 Jun 2023 12:41:21 +0000 Subject: [PATCH] Bug 34075: Add DefaultAuthorityTab system preference This patch adds a new system preference, DefaultAuthorityTab. When set, this will choose the default display on the authorities details page. To test: 1 - Apply patch, update database 2 - View an authority detail 3 - You should default to the 0XX or first tab 4 - Set DefaultAuthorityTab to a number that there is no tab for in your authority 5 - Reload and verify details page loads the first tba 6 - Set DefaultAuthorityTab to 1XX or another tab that exists in your record 7 - Reload the details and confirm the correct tab is selected Signed-off-by: Sam Lau Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi --- installer/data/mysql/atomicupdate/bug_34075.pl | 15 +++++++++++++++ installer/data/mysql/mandatory/sysprefs.sql | 1 + .../modules/admin/preferences/authorities.pref | 17 ++++++++++++++++- .../prog/en/modules/authorities/detail.tt | 14 +++++++++++++- 4 files changed, 45 insertions(+), 2 deletions(-) create mode 100755 installer/data/mysql/atomicupdate/bug_34075.pl diff --git a/installer/data/mysql/atomicupdate/bug_34075.pl b/installer/data/mysql/atomicupdate/bug_34075.pl new file mode 100755 index 0000000000..fe83258dfe --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_34075.pl @@ -0,0 +1,15 @@ +use Modern::Perl; + +return { + bug_number => "34075", + description => "Add DefaultAuthorityTab system preference", + up => sub { + my ($args) = @_; + my ($dbh, $out) = @$args{qw(dbh out)}; + $dbh->do(q{ + INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES + ('DefaultAuthorityTab','0','0|1|2|3|4|5|6|7|8|9','Default tab to shwo when displaying authorities','Choice') + }); + say $out "Added new system preference 'DefaultAuthorityTab'"; + }, +}; diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql index 722d34e97b..ce6930ebe9 100644 --- a/installer/data/mysql/mandatory/sysprefs.sql +++ b/installer/data/mysql/mandatory/sysprefs.sql @@ -174,6 +174,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('decreaseLoanHighHoldsDuration',NULL,'','Specifies a number of days that a loan is reduced to when used in conjunction with decreaseLoanHighHolds','Integer'), ('decreaseLoanHighHoldsIgnoreStatuses', '', 'damaged|itemlost|notforloan|withdrawn', "Ignore items with these statuses for dynamic high holds checking", 'Choice'), ('decreaseLoanHighHoldsValue',NULL,'','Specifies a threshold for the minimum number of holds needed to trigger a reduction in loan duration (used with decreaseLoanHighHolds)','Integer'), +('DefaultAuthorityTab','0','0|1|2|3|4|5|6|7|8|9','Default tab to shwo when displaying authorities','Choice'), ('DefaultClassificationSource','ddc',NULL,'Default classification scheme used by the collection. E.g., Dewey, LCC, etc.','ClassSources'), ('DefaultCountryField008','','','Fill in the default country code for field 008 Range 15-17 of MARC21 - Place of publication, production, or execution. See MARC Code List for Countries','Free'), ('DefaultHoldExpirationdate','0','','Automatically set expiration date for holds','YesNo'), diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref index 787906e1cc..eabea67147 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref @@ -75,7 +75,22 @@ Authorities: default: "Work cat." type: textarea class: code - + - + - When viewing authority details default to the + - pref: DefaultAuthorityTab + default: "0" + choices: + "0": 0XX + "1": 1XX + "2": 2XX + "3": 3XX + "4": 4XX + "5": 5XX + "6": 6XX + "7": 7XX + "8": 8XX + "9": 9XX + - tab. If the selected tab does not exist, the view will default to the first tab. Linker: - - Use the diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt index 2392e86dff..b6b624665c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt @@ -1,4 +1,5 @@ [% USE raw %] +[% USE Koha %] [% USE Asset %] [% PROCESS 'i18n.inc' %] [% SET footerjs = 1 %] @@ -135,7 +136,18 @@