From 5574a5850f2a55a3544b3f9d5c95bf491aae4e03 Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Thu, 11 Jun 2020 13:05:31 +0100
Subject: [PATCH] Bug 25239: Fix semantic heading for opac-reserve.tt

Prior to this patch, the opac-reserve contained semantically incorrect headings.

Test plan
1/ Perform a search which yields some results in the OPAC
2/ Attempt to place a hold on an item.
3/ On the resulting screen, note that the headings are:
   H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels)
4/ Apply this patch and reload the page
5/ Re-inspect the elements in question note the heading semantics are now:
   H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels)
6/ Note the appearance of the box is still reasonable
7/ Signoff

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 1a96ede5f114bd90fe1735702ca4bab77dfed9d4)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
index 9e73090c6e..bafd73c4a4 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
@@ -131,7 +131,7 @@
 
             [% UNLESS ( message ) %]
                 [% UNLESS ( none_available ) %]
-                    <h3>Confirm holds for:[% INCLUDE 'patron-title.inc' patron = logged_in_user %] ([% logged_in_user.cardnumber | html %])</h3>
+                    <h2>Confirm holds for:[% INCLUDE 'patron-title.inc' patron = logged_in_user %] ([% logged_in_user.cardnumber | html %])</h2>
                 [% END # / UNLESS none_available %]
 
                 [% IF (RESERVE_CHARGE) %]
@@ -161,7 +161,7 @@
                                     [% IF ( bibitemloo.holdable ) %]
                             <div class="holdrow">
                                 [% IF bibitemloo.forced_hold_level %]
-                                    <span class="forced_hold_level"><h5>
+                                    <span class="forced_hold_level"><h3>
                                         [% IF bibitemloo.forced_hold_level == 'item' %]
                                             You already have at least one item level hold on this title.
                                             All further holds must be item level.
@@ -169,7 +169,7 @@
                                             You already have at least one record level hold on this title.
                                             All further holds must be record level.
                                         [% END %]
-                                    </h5></span>
+                                    </h3></span>
                                 [% END %]
                                 <p>
                                         <input class="reserve_mode" name="reserve_mode" type="hidden" value="single"/>
-- 
2.39.5