From 5d2bb877fbde221d9898a62959de53ba6d0de180 Mon Sep 17 00:00:00 2001
From: David Cook <dcook@prosentient.com.au>
Date: Thu, 11 Aug 2022 05:40:45 +0000
Subject: [PATCH] Bug 31294: Show "Required" label on mandatory fields

This patch adds "Required" label on mandatory fields for Article Requests

0. Apply the patch
1. koha-plack --restart kohadev
2. Change syspref 'ArticleRequests' to 'Enable'
3. Change syspref 'ArticleRequestsMandatoryFields' to '[Select all]'
4. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
5. Click "Request article" for "Gairm"
6. Note that "Title", "Author", "Volume", "Issue", "Date", "Pages", and
   "Chapters" all say required
7. Change syspref 'ArticleRequestsMandatoryFields' to 'Title' and
   'Author'
8. Go to http://localhost:8080/cgi-bin/koha/opac-request-article.pl?biblionumber=29
9. Note that only "Title" and "Author" say required

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 5c1db538e6c25da27484e39ae619e09779aac1c2)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 369087c7de556078a31a4371d24b4f8a77510006)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
---
 .../opac-tmpl/bootstrap/en/modules/opac-request-article.tt | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt
index 88801bac4e..d96e3a7d75 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt
@@ -68,6 +68,7 @@
                                         [% IF mandatory_fields.search('title') %]
                                             <label for="title" class="required">Title:</label>
                                             <input type="text" required="required" name="title" id="title" size="50" value="[% title | html %]"/>
+                                            <div class="required_label required">Required</div>
                                         [% ELSE %]
                                             <label for="title">Title:</label>
                                             <input type="text" name="title" id="title" size="50" value="[% title | html %]"/>
@@ -78,6 +79,7 @@
                                         [% IF mandatory_fields.search('author') %]
                                             <label for="author" class="required">Author:</label>
                                             <input type="text" required="required" name="author" id="author" size="50" value="[% author | html %]"/>
+                                            <div class="required_label required">Required</div>
                                         [% ELSE %]
                                             <label for="author">Author:</label>
                                             <input type="text" name="author" id="author" size="50" value="[% author | html %]"/>
@@ -88,6 +90,7 @@
                                         [% IF mandatory_fields.search('volume') %]
                                             <label for="volume" class="required">Volume:</label>
                                             <input type="text" required="required" name="volume" id="volume" size="50"/>
+                                            <div class="required_label required">Required</div>
                                         [% ELSE %]
                                             <label for="volume">Volume:</label>
                                             <input type="text" name="volume" id="volume" size="50"/>
@@ -98,6 +101,7 @@
                                         [% IF mandatory_fields.search('issue') %]
                                             <label for="issue" class="required">Issue:</label>
                                             <input type="text" required="required" name="issue" id="issue" size="50"/>
+                                            <div class="required_label required">Required</div>
                                         [% ELSE %]
                                             <label for="issue">Issue:</label>
                                             <input type="text" name="issue" id="issue" size="50"/>
@@ -108,6 +112,7 @@
                                         [% IF mandatory_fields.search('date') %]
                                             <label for="date" class="required">Date:</label>
                                             <input type="text" required="required" name="date" id="date" size="50"/>
+                                            <div class="required_label required">Required</div>
                                         [% ELSE %]
                                             <label for="date">Date:</label>
                                             <input type="text" name="date" id="date" size="50"/>
@@ -123,6 +128,7 @@
                                         [% IF mandatory_fields.search('pages') %]
                                             <label for="pages" class="required">Pages:</label>
                                             <input type="text" required="required" name="pages" id="pages" size="50" value="[% pageinfo | html %]"/>
+                                            <div class="required_label required">Required</div>
                                         [% ELSE %]
                                             <label for="pages">Pages:</label>
                                             <input type="text" name="pages" id="pages" size="50" value="[% pageinfo | html %]"/>
@@ -133,6 +139,7 @@
                                         [% IF mandatory_fields.search('chapters') %]
                                             <label for="chapters" class="required">Chapters:</label>
                                             <input type="text" required="required" name="chapters" id="chapters" size="50"/>
+                                            <div class="required_label required">Required</div>
                                         [% ELSE %]
                                             <label for="chapters">Chapters:</label>
                                             <input type="text" name="chapters" id="chapters" size="50"/>
-- 
2.20.1