From 681b8432468056c75f86edb6e6179a7b04f87b57 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Tue, 21 Sep 2021 16:32:00 +0000 Subject: [PATCH] Bug 28934: Make the OPAC registration form design consistent The gender/sex and GDPR inputs were slightly misaligned (by 1.5em). Now they are aligned with the other inputs which have a width of 10em (9em width + margin 1em). The label assignments and required attributes for input elements are made also consistent. To test: 1) Enable GDPR_Policy syspref 2) Apply patch, run "yarn build --view opac", restart plack 3) Go to /cgi-bin/koha/opac-memberentry.pl 4) Check that the GDPR input box shows the required text now in red color 5) Check that the alignment of sex/gender and GDPR input matches with the other inputs perfectly. Signed-off-by: Hayley Pelham Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall --- .../opac-tmpl/bootstrap/css/src/opac.scss | 23 +++++++++++++++++-- .../bootstrap/en/modules/opac-memberentry.tt | 13 ++++++++--- 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss index 96d6677f0b..aaab5a7cf0 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss +++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss @@ -699,6 +699,13 @@ fieldset { font-weight: bold; } + div.label { + display: inline-block; + width: 9rem; + margin-right: 1rem; + float: none; + } + label, .label { float: left; @@ -708,10 +715,19 @@ fieldset { width: 9rem; } + label.checkbox-label { + float: none; + margin-right: 0; + font-weight: normal; + text-align: left; + width: auto; + } + label { &.error { color: #C00; float: none; + display: inline; font-style: italic; font-weight: normal; margin-left: 1rem; @@ -749,6 +765,7 @@ fieldset { } } + li { clear: left; float: left; @@ -757,14 +774,16 @@ fieldset { width: 100%; &.lradio { - padding-left: 8.5em; width: auto; label { float: none; - margin: 0 0 0 1em; + margin: 0; width: auto; } + input { + margin-right: 1rem; + } } } diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index 65f2ee6108..b279717860 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -373,6 +373,7 @@ [% UNLESS hidden.defined('sex') %]
  • +
    [% IF borrower.sex == 'F' %] @@ -814,11 +815,11 @@
      -
    1. +
    2. Required
    3. -
    4. +
    5. Required
    6. @@ -901,7 +902,13 @@ GDPR consent
      1. - I agree with your processing of my personal data as outlined in the privacy policy.
        Required
        +
        + + +
        Required
      -- 2.39.5