From 87ae49399da34c5e9db954a0edb693335faea53e Mon Sep 17 00:00:00 2001 From: Aleisha Date: Thu, 31 Mar 2016 21:24:21 +0000 Subject: [PATCH] Bug 16182: Make phone number clickable to call EDIT: fixing typo, changing sms number from tel: to sms: To test: 1) Go to a patron detail page 2) Confirm that all available phone numbers can be clicked and allow you to call this number from your device a) in the top left circ-menu.inc b) primary/secondary/other/organisation/mobile phone numbers c) alternate address phone number d) alternate contact phone number e) enable the EnhancedMessagingPreferences system preference. check the SMS number under Patron messaging preferences (back on the detail page) is clickable 3) Check to see if there are any phone numbers I have missed. Sponsored-by: Catalyst IT Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall --- .../prog/en/includes/circ-menu.inc | 7 +++---- .../prog/en/modules/members/moremember.tt | 18 +++++++++--------- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index f545afac23..1d6dc9b774 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -20,13 +20,13 @@ [% END %] [% IF ( phone ) %]
  • - [% phone %] + [% phone %] [% ELSE %] [% IF ( mobile ) %] - [% mobile %] + [% mobile %] [% ELSE %] [% IF ( phonepro ) %] - [% phonepro %] + [% phonepro %] [% END %] [% END %]
    • [% END %] @@ -107,4 +107,3 @@ [% END %] [% END %] - diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt index 6a4add02dd..ccb817ca97 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ -212,17 +212,17 @@ function validate1(date) {
      [% IF ( I ) %] - [% IF ( phonepro ) %]
    1. Organization phone: [% phonepro %]
      2. [% END %] + [% IF ( phonepro ) %]
    2. Organization phone: [% phonepro %]
      3. [% END %] [% IF ( emailpro ) %][% END %] [% ELSE %] - [% IF ( phone ) %]
    3. Primary phone: [% phone %]
      4. [% END %] - [% IF ( phonepro ) %]
    4. Secondary phone: [% phonepro %]
      5. [% END %] - [% IF ( mobile ) %]
    5. Other phone: [% mobile %]
      6. [% END %] + [% IF ( phone ) %]
    6. Primary phone: [% phone %]
      7. [% END %] + [% IF ( phonepro ) %]
    7. Secondary phone: [% phonepro %]
      8. [% END %] + [% IF ( mobile ) %]
    8. Other phone: [% mobile %]
      9. [% END %] [% END %] [% IF ( P ) %] - [% IF ( phone ) %]
    9. Primary phone: [% phone %]
      10. [% END %] - [% IF ( mobile ) %]
    10. Other phone: [% mobile %]
      11. [% END %] + [% IF ( phone ) %]
    11. Primary phone: [% phone %]
      12. [% END %] + [% IF ( mobile ) %]
    12. Other phone: [% mobile %]
      13. [% END %] [% END %] [% IF ( fax ) %]
    13. Fax: [% fax %]
      14. [% END %] [% UNLESS ( I ) %] @@ -336,7 +336,7 @@ function validate1(date) {

      Patron messaging preferences

      [% INCLUDE 'messaging-preference-form.inc' %] [% IF ( SMSSendDriver ) %] -
      1. SMS number:[% SMSnumber %] +
        1. SMS number:[% SMSnumber %]
        [% END %]
      @@ -414,7 +414,7 @@ function validate1(date) { [% IF ( B_state ) %]
    14. State: [% B_state %]
      15. [% END %]
    15. ZIP/Postal code: [% B_zipcode %]
      16. [% IF ( B_country ) %]
    16. Country: [% B_country %]
      17. [% END %] - [% IF ( B_phone ) %]
    17. Phone: [% B_phone %]
      18. [% END %] + [% IF ( B_phone ) %]
    18. Phone: [% B_phone %]
      19. [% END %] [% IF ( B_email ) %][% END %] [% IF ( contactnote ) %]
    19. Contact note: [% contactnote %]
      20. [% END %]
    @@ -433,7 +433,7 @@ function validate1(date) { [% IF ( altcontactstate ) %]
  • State: [% altcontactstate %]
    • [% END %]
  • ZIP/Postal code: [% altcontactzipcode %]
    • [% IF ( altcontactcountry ) %]
  • Country: [% altcontactcountry %]
    • [% END %] - [% IF ( altcontactphone ) %]
  • Phone: [% altcontactphone %]
    • [% END %] + [% IF ( altcontactphone ) %]
  • Phone: [% altcontactphone %]
    • [% END %]
    Edit
    -- 2.39.5