From 8984ea2f411227e8b7261fd1df53341005a14441 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 28 Jul 2016 14:33:16 -0400
Subject: [PATCH] Bug 16995 - Remove event attributes from two include files

This patch removes event attributes from two include files:
cat-toolbar.inc and members-toolbar.inc.

In cat-toolbar.inc an unused <form> tag with an "onsubmit" attribute has
been removed.

To test, apply the patch and:

- View the detail page for any bibliographic record. All toolbar buttons
  ("New," "Edit," "Save," etc.) should work as expected.
- View the detail page for any patron. Click the "Add message" button in
  the toolbar. Selecting a predefined note should correctly populate the
  textarea with your selected message.

Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 3 ---
 .../intranet-tmpl/prog/en/includes/members-toolbar.inc   | 9 ++++++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
index 68aeefaa0a..b809c4e742 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
@@ -127,8 +127,6 @@
 
 <div id="toolbar" class="btn-toolbar">
 
-<form method="post" name="f" id="f" action="/cgi-bin/koha/cataloguing/addbiblio.pl" onsubmit="return Check();">
-
 [% IF ( CAN_user_editcatalogue_edit_catalogue || CAN_user_editcatalogue_edit_items ||
 CAN_user_serials_create_subscription ) %]
     <div class="btn-group">
@@ -263,7 +261,6 @@ CAN_user_serials_create_subscription ) %]
     [% END %]
 [% END %]
 
-</form>
 </div>
 
     <!--Modal for Dublin Core-->
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
index 9eb1f65f12..cd405e5832 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
@@ -67,7 +67,10 @@ $(document).ready(function(){
     $("#searchtohold").click(function(){
         searchToHold();
         return false;
-    })
+    });
+    $("#select_patron_messages").on("change",function(){
+        $("#borrower_message").val( $(this).val() );
+    });
 });
 function confirm_local_deletion() {
     var is_confirmed = window.confirm(_("Are you sure you want to delete this patron from the local database? This cannot be undone."));
@@ -226,8 +229,8 @@ function searchToHold(){
                 [% bor_notes = AuthorisedValues.Get( 'BOR_NOTES' ) %]
                 [% IF bor_notes %]
                     <li>
-                        <label for="type">Predefined notes: </label>
-                        <select name="type" id="type" onchange="this.form.borrower_message.value=this.options[this.selectedIndex].value;">
+                        <label for="select_patron_messages">Predefined notes: </label>
+                        <select name="type" id="select_patron_messages">
                             <option value="">Select note</option>
                             [% FOREACH bor_note IN bor_notes %]
                                 <option value="[% bor_note.lib %]">[% bor_note.lib %]</option>
-- 
2.39.2