From a89a203c1c85841a09b49771adbd77eeb76180c2 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 11 Jun 2019 18:13:08 +0000
Subject: [PATCH] Bug 23099: OPAC Search result sorting "go" button flashes on
 page load

There are a few places in the OPAC where we hide the submit button on a
sorting form because the form auto-submits when the selection changes.
These should be hidden using CSS instead of JS to prevent the temporary
appearance of the submit button while the page loads.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Test OPAC search results and OPAC checkout history. On both pages you
should not see a "Go" button next to the <select> input for changing the
sort order.

Disable JavaScript in your browser and test those pages again. The "Go"
button should appear.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss           | 8 ++++++++
 .../opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt  | 1 -
 .../bootstrap/en/modules/opac-results-grouped.tt          | 1 -
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt  | 1 -
 4 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
index 1e389c2ab9..f2fea4ab62 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
@@ -17,12 +17,20 @@ $footer-height: 45px;
     .selections-toolbar {
         display: none;
     }
+
+    #sortsubmit {
+        display: inline;
+    }
 }
 
 .js {
     .dateformat {
         display: none;
     }
+
+    #sortsubmit {
+        display: none;
+    }
 }
 
 .fa.fa-icon-black,
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
index 876b55b08f..238b2e534c 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
@@ -210,7 +210,6 @@
 <script>
     $(document).ready(function(){
         [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %]
-            $('#sortsubmit').hide();
         $('#order').change(function() {
             $('#sortform').submit();
         });
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
index 4952376704..1001aab19d 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
@@ -298,7 +298,6 @@ $(document).ready(function(){
         });
     [% END %]
 
-    $('#sortsubmit').hide();
     $('#sort_by').change(function() {
         $('#bookbag_form').submit();
     });
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
index c0cf164d02..12c9a2d1c6 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
@@ -832,7 +832,6 @@ $(document).ready(function(){
     param1 += "<\/select> <input type=\"submit\" class=\"btn btn-small\" value=\""+_("Save")+"\" />";
 [% END %]
 
-    $('#sortsubmit').hide();
     $('.resort').change(function() {
         $('#bookbag_form').submit();
     });
-- 
2.39.5