From b10162f3a2086be33abd3df45e717d7c6e902388 Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 3 Sep 2020 05:40:57 +0000 Subject: [PATCH] Bug 26362: Show correct libraries in overdues report Currently the overdues report does the following display: Patron library = home branch Home library = holding branch Holding library = patron branch This patch corrects the display of libraries in the overdues report. To test: 0) Do not apply patch 1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl 3) Choose "Troy" 4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 5) Checkout "39999000004571" with due date of "09/01/2019 23:59" Note the facts: Patron library = Centerville Home library = Fairview Holding library = Troy 6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 7) Change "Columns" visibility to show Holding and Home libraries 8) Note that the libraries are incorrect: Patron library appears to be: Fairview Home library appears to be: Troy Holding library appears to be: Centerville 9) Apply the patch 10) koha-plack --restart kohadev 11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 12) Change "Columns" visibility to show Holding and Home libraries 13) Note that the libraries are correct: Patron library appears to be: Centerville Home library appears to be: Fairview Holding library appears to be: Troy Signed-off-by: Emmi Takkinen Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit b729886216560fdf50d88dc8214c0dbb58720b5c) Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt index 1e29484a70..d19d0456b5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt @@ -78,10 +78,10 @@ [% IF ( overdueloo.phone ) %]([% overdueloo.phone | html %])[% ELSIF ( overdueloo.mobile ) %]([% overdueloo.mobile | html %])[% ELSIF ( overdueloo.phonepro ) %]([% overdueloo.phonepro | html %])[% END %] [% END %] [% Categories.GetName( overdueloo.patron.categorycode ) | html %] - [% Branches.GetName( overdueloo.homebranchcode ) | html %] + [% Branches.GetName( overdueloo.patron.branchcode ) | html %] [% INCLUDE 'biblio-default-view.inc' biblionumber = overdueloo.biblionumber %][% INCLUDE 'biblio-title.inc' biblio=overdueloo %] [% IF ( overdueloo.author ) %], by [% overdueloo.author | html %][% END %][% IF ( overdueloo.enumchron ) %], [% overdueloo.enumchron | html %][% END %] + [% Branches.GetName( overdueloo.homebranchcode ) | html %] [% Branches.GetName( overdueloo.holdingbranchcode ) | html %] - [% Branches.GetName( overdueloo.patron.branchcode ) | html %] [% overdueloo.barcode | html %] [% overdueloo.itemcallnumber | html %] [% ItemTypes.GetDescription( overdueloo.itemtype ) | html %] -- 2.39.2