From d4daf32d1d4fdadbf677d7520e22b0a463b5ab8f Mon Sep 17 00:00:00 2001 From: Samuel Crosby Date: Mon, 30 Dec 2013 14:52:49 +1100 Subject: [PATCH] Bug 9654: add space between amount and currency symbol in basket group display Changed: $total .= $bookseller->{invoiceprice} // 0; Into: $total .= " " . ($bookseller->{invoiceprice} // 0); in order to add a space between the total and currency in the basket group. Revised test plan: 1) Log into staff client 2) Acquisitions 3) Click 'Search' in the 'Manage orders' box. 4) Click '+ New basket' beside a vendor name. 5) Type 'Bug 9654 Test 1' into basket name. 6) Click 'Save' 7) Click 'Add to basket' 8) Click 'From an external source' 9) Type 'Green Eggs and Ham' into the Title text box. 10) Click 'Search' 11) Click 'Order' on any one of the results. 12) Click 'Add Item' in the 'Item' box. 13) Select a Fund from the dropdown in the 'Accounting details' box. 14) Click 'Save' 15) Click 'Close this basket' 16) Click 'Yes, close (Y)' without checking the attach to a basket group. 17) Click the 'Basket groups' tab. 18) Click '+ New basket group' 19) Notice the listing in 'Ungrouped baskets' lacks a space between the number and the currency. (e.g. Total: 0USD) 20) Apply patch (git bz apply 9654) 21) Refresh the page 22) Notice there is now a space. (e.g. Total: 0 USD) 23) Run the Koha QA Tool: (~/qa-test-tools/koha-qa.pl -v 2 -c 1) Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Works as described, passes all tests. Signed-off-by: Galen Charlton --- acqui/basketgroup.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl index 36c446224f..7067ba9ab6 100755 --- a/acqui/basketgroup.pl +++ b/acqui/basketgroup.pl @@ -145,7 +145,7 @@ sub BasketTotal { $total = $total * ( $gst / 100 +1); } } - $total .= $bookseller->{invoiceprice} // 0; + $total .= " " . ($bookseller->{invoiceprice} // 0); return $total; } -- 2.39.2