From f213ad6150f1f6e1aebcd4c335e1516e86fbeb6b Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 29 Oct 2021 13:09:41 +0000 Subject: [PATCH] Bug 29228: Use Flatpickr on offline circulation page This patch replaces the use of jQueryUI datepicker on the built-in offline circulation page, where it was used for the "Specify due date" date-time picker as well as for formatting datetime values for display. To test, apply the patch and go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click "Download records." - Submit a card number for a patron who has multiple items checked out. - In the table of previous checkouts, confirm that dates in the "Date due" and "Checked out on" columns are formatted according to your TimeFormat and DateFormat system preferences. - When checking out to a patron with fines, open the fines tab and submit an amount in payment. The table of payments should include a correctly-formatted datetime. - Test that the "Specify due date" date picker works correctly and that checkouts show the correct date. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Fridolin Somers --- .../prog/en/modules/circ/offline.tt | 47 ++++++++++--------- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt index 9c5e1fbc30..75c05621d4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt @@ -199,7 +199,7 @@ - + @@ -260,6 +260,10 @@ var start; var dateformat = '[% IF ( dateformat_us ) %]mm/dd/yy[% ELSIF ( dateformat_metric ) %]dd/mm/yy[% ELSE %]yy-mm-dd[% END %]'; + var flatpickr_dateformat_string = [% IF ( dateformat == "us" ) %]"m/d/Y"[% ELSIF ( dateformat == "metric" ) %]"d/m/Y"[% ELSIF ( dateformat == "dmydot" ) %]"d.m.Y"[% ELSE %]"Y-m-d"[% END %]; + var flatpickr_timeformat_string = [% IF Koha.Preference('TimeFormat') == '12hr' %]"G:i K"[% ELSE %]"H:i"[% END %]; + var flatpickr_timestamp_string = "Y-m-d H:i"; + var flatpickr_datetime_string = flatpickr_dateformat_string + " " + flatpickr_timeformat_string; function checkin(barcode, item, error) { var alerts = checkAlerts(barcode, item); @@ -360,10 +364,15 @@ } + function fPformatTimeStamp( timestamp ){ + var datetimeObj = flatpickr.parseDate( timestamp, flatpickr_timestamp_string ); + return flatpickr.formatDate( datetimeObj, flatpickr_datetime_string ); + } + function showTimestamp(key, value) { if (typeof value !== 'undefined') { var ts = new Date(value); - $('#' + key).text($.datepicker.formatDate(dateformat, ts) + ' ' + ts.toTimeString()); + $('#' + key).text( fPformatTimeStamp( ts ) + ' ' + ts.toTimeString()); } else { $('#' + key).text(_("(never)")); } @@ -473,7 +482,7 @@ $('#oldissuest tbody').empty(); issuesidx.each(function (item) { $('#oldissues').show(); - $('#oldissuest tbody').append("" + item.value.date_due + "" + item.value.title + "" + item.value.barcode + "" + item.value.itype + "" + item.value.issuedate + "" + item.value.issuebranch + "" + item.value.callnumber + "" + "" + ""); + $('#oldissuest tbody').append("" + fPformatTimeStamp( item.value.date_due ) + "" + item.value.title + "" + item.value.barcode + "" + item.value.itype + "" + fPformatTimeStamp( item.value.issuedate ) + "" + item.value.issuebranch + "" + item.value.callnumber + "" + "" + ""); $('.checkout-count').text(parseInt($('.checkout-count').text()) + 1); }, barcode); }); @@ -495,7 +504,7 @@ setTimeout(function() { $('#duedatespec').trigger('focus'), 1 }); return; } - var date_due = new Date($('#duedatespec').datepicker('getDate')); + var date_due = flatpickr.parseDate( $('#duedatespec').val(), flatpickr_datetime_string ); var trans = { "timestamp" : new Date().toMySQLString(), "barcode" : barcode, "cardnumber" : curpatron.cardnumber, @@ -505,7 +514,7 @@ $('#alerts').empty(); kohadb.recordTransaction(trans, function () { $('#session-issues').show(); - $('#issuest tbody').prepend('' + $.datepicker.formatDate(dateformat, date_due) + date_due.toTimeString() + '' + item.title + '' + barcode + '' + item.itemtype + '' + $.datepicker.formatDate(dateformat, new Date()) + '' + kohadb.settings.branchcode + '' + item.callnumber + ''); + $('#issuest tbody').prepend('' + flatpickr.formatDate( date_due, flatpickr_datetime_string ) + '' + item.title + '' + barcode + '' + item.itemtype + '' + flatpickr.formatDate( new Date(), flatpickr_datetime_string ) + '' + kohadb.settings.branchcode + '' + item.callnumber + ''); $('.checkout-count').text(parseInt($('.checkout-count').text()) + 1); if (alerts.length > 0) { $('#alerts').append('

' + _("Check out message") + '

'); @@ -526,7 +535,7 @@ }; kohadb.recordTransaction(trans, function () { $('#session-payments').show(); - $('#session-payments tbody').prepend('' + amount + '' + $.datepicker.formatDate(dateformat, timestamp) + timestamp.toTimeString() + ''); + $('#session-payments tbody').prepend('' + amount + '' + fPformatTimeStamp( timestamp ) + ''); $('.fine-amount').text(parseInt($('.fine-amount').text()) - amount); }); } @@ -544,13 +553,13 @@ } if (patron.debarred !== null) { if (patron.debarred != '9999-12-31') { - alerts.push(ALERT_PATRON_BLOCKED_TEMPORARY.format($.datepicker.formatDate(dateformat, new Date(patron.debarred)))); + alerts.push( ALERT_PATRON_BLOCKED_TEMPORARY.format( flatpickr.formatDate( new Date(patron.debarred), flatpickr_datetime_string ) ) ); } else { alerts.push(ALERT_PATRON_RESTRICTED); } } if (new Date(patron.dateexpiry) < new Date()) { - alerts.push(ALERT_PATRON_EXPIRED.format($.datepicker.formatDate(dateformat, new Date(patron.dateexpiry)))); + alerts.push( ALERT_PATRON_EXPIRED.format( flatpickr.formatDate( new Date(patron.dateexpiry), flatpickr_datetime_string ) ) ); } if (parseInt(patron.fine) > [% maxoutstanding | html %]) { alerts.push(ALERT_PATRON_FINE_OVER_LIMIT.format(patron.fine)); @@ -766,22 +775,14 @@ $('#patronlists').tabs(); - $("#newduedate").datetimepicker({ - minDate: 1, // require that renewal date is after today - hour: 23, - minute: 59 - }); - $("#duedatespec").datetimepicker({ - onClose: function(dateText, inst) { - if (validate_date(dateText, inst) ) { - setTimeout(function() { $('#checkout-barcode').trigger('focus'), 1 }); - } - }, - hour: 23, - minute: 59 - }).on("change", function(e, value) { - if ( ! is_valid_date( $(this).val() ) ) {$(this).val("");} + $("#duedatespec").flatpickr({ + enableTime: true, + dateFormat: flatpickr_datetime_string, + onClose: function() { + $("#checkout-barcode").focus(); + } }); + $('#mainform').submit(function (event) { event.preventDefault(); var barcode = $('#checkout-barcode').val(); -- 2.39.5