From f73ed6655d41c9a518ead7a9c42b4e882d33b186 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 31 Aug 2023 17:05:57 +0200 Subject: [PATCH] Bug 34684: Prevent 220600007.pl to fail if run twice The error is ERROR 1292 (22007): Truncated incorrect DECIMAL value: 'no' Happens on MariaDB 10.5.22, not MySQL 8 Test plan: update systempreferences set value="0" where variable="DisplayClearScreenButton"; play installer/data/mysql/db_revs/220600007.pl select value from systempreferences where variable="DisplayClearScreenButton"; => "no" update systempreferences set value="1" where variable="DisplayClearScreenButton"; play installer/data/mysql/db_revs/220600007.pl select value from systempreferences where variable="DisplayClearScreenButton"; => "issueslip" Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 027e1e18620e3c790e85ea49b3870f9ee7785871) Signed-off-by: Fridolin Somers --- installer/data/mysql/db_revs/220600007.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/installer/data/mysql/db_revs/220600007.pl b/installer/data/mysql/db_revs/220600007.pl index 8fc89a37d8..8e8a786c1f 100755 --- a/installer/data/mysql/db_revs/220600007.pl +++ b/installer/data/mysql/db_revs/220600007.pl @@ -13,7 +13,7 @@ return { options = 'no|issueslip|issueqslip', type = 'Choice', value = CASE value - WHEN 1 THEN 'issueslip' + WHEN "1" THEN 'issueslip' ELSE 'no' END WHERE variable = 'DisplayClearScreenButton'; -- 2.39.5