]> git.koha-community.org Git - koha.git/commit
Bug 29464: Make GET /acquisitions/orders honour sorting
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 10 Dec 2021 13:17:45 +0000 (10:17 -0300)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Mon, 31 Jan 2022 15:25:56 +0000 (15:25 +0000)
commitadc5a4def682fcd110b491b0613c7b0a622d7369
treeddbc4f6719d3478c55f9e737228049516bdb6905
parent6dbc8ac8b4db58b3e9e12b54f329dcb2ccaed0e2
Bug 29464: Make GET /acquisitions/orders honour sorting

When bug 20212 was pushed, we lost (didn't dig enough to find out how)
the sorting feature for this route.

This is mainly because biblio+biblioitems filtering prevents the route
to use plain $c->objects->search, so it has baked a custom version of
it. In this case, it missed the call to the dbic_merge_sorting helper,
that takes care of reading the query parameters and inject the sorting
attributes to the resultset.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisitions_orders.t
=> FAIL: Tests fail, sorting doesn't actually work
3. Apply this patch
4. Repeat 2
=> SUCCESS: Sorting works!
5. Test sorting the pending orders on parcel.tt
6. Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/REST/V1/Acquisitions/Orders.pm