From 47223f0cad47913c15f4c9dacfbc0ed4682a8e2d Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Fri, 1 Sep 2017 21:23:20 -0400 Subject: [PATCH] Bug 19120: Leave cancelled ordered items alone when reopening basket TEST PLAN --------- 1) Apply first patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS 3) Apply this patch 4) prove t/db_dependent/Acquisition/close_reopen_basket.t -- SUCCESS! 5) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 632e2ad51d2510a412224ded5e51a9f991d566b4) Signed-off-by: Fridolin Somers --- C4/Acquisition.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index d4612184d2..cff2e53013 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -261,7 +261,7 @@ sub ReopenBasket { UPDATE aqorders SET orderstatus = 'new' WHERE basketno = ? - AND orderstatus != 'complete' + AND orderstatus NOT IN ( 'complete', 'cancelled' ) }, {}, $basketno); return; } -- 2.39.5