From 441c282779d729d0ca9d2ae99cd491fb011477d0 Mon Sep 17 00:00:00 2001 From: The Minh Luong Date: Tue, 25 Jan 2022 12:20:38 -0500 Subject: [PATCH] Bug 28975: Holds queue lists can show holds from all libraries even with IndependentBranches When using IndependentBranches, usually all branches are removed from the drop-down menus. But in the Holds Queue page, there is the possibility to choose "All branches". From there, you can see holds from all libraries. To recreate : 1) Activate IndependentBranches, IndependentBranchesPatronModifications and IndependentBranchesTransfers 2) Create a staff user with limited permissions (NOT a superlibrarian), including holds permissions. Here are mine as an example - circulate (all) - catalogue - borrowers - delete_borrowers - edit_borrowers - reserveforothers (all) - reports (all) 3) Create (or make sure you already have) a patron in another branch (we'll call them patron X) 4) Place a hold for patron X on an available item from their own library 5) Run misc/cronjobs/holds/build_holds_queue.pl 6) Go to Circulation > Holds queue and make sure you can see the hold 7) Log in as your limited staff patron 8) Go to Circulation > Holds queue 9) In the drop-down menu, choose "All" and click Submit -- Notice you see the hold of the patron from another branch under Patron column: "A patron from library " 11) Apply the patch. 12) Notice that the "All" option is no longer available for the limited patron. Limited patrons can't see holds from other libraries anymore. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit fe2e2f9400714341877958853e8165db517fe1fa) Signed-off-by: Matt Blenkinsop (cherry picked from commit 6d2756b7d7f0203d9ab0a7f5900da0b19954a17b) Signed-off-by: Lucas Gass (cherry picked from commit 2a2ffb4fcfce49f1fee8fa698160f52ad408fd5e) Signed-off-by: Arthur Suzuki --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt index b3c73577b2..1ed1f034d4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt @@ -237,7 +237,9 @@
    • -- 2.39.5