]> git.koha-community.org Git - koha.git/commit
Bug 15009 - Planning dropdown button in aqbudget can have empty line
authorBlou <philippe.blouin@inlibro.com>
Tue, 13 Oct 2015 20:12:49 +0000 (16:12 -0400)
committerJulian Maurice <julian.maurice@biblibre.com>
Mon, 16 May 2016 12:01:03 +0000 (14:01 +0200)
commit76aba15a35aa49895ea389cbad607135f9632eca
treec3b10850f9b710bfa5c93d2b419881b0dd56c7d7
parent1ccf956b536fcbc5c67530e9edbe9d0de4773af4
Bug 15009 - Planning dropdown button in aqbudget can have empty line

When displaying a budget, the Planning button in the admin toolbar displays

Plan by months
Plan by libraries
Plan by item types
Plan by

The last one is empty, due to C4::Budgets::GetBudgetAuthCats returning an empty field if the budget has no sort defined.
This prevents returning an array with empty element(s)

TEST:
1) Admin -> Budgets
2) Select a budget
   a) you must have '' (empty) in your aqbudgets.sort1_authcat field.
   b) edit the budget (direct DB or interface) to get that.
3) Click on Planning dropdown, see the "Plan by <nothing> " entry.
4) apply the patch, revalidate.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No more empty option
No errors

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit b8076d8ec7236360274e1a4e861969c86bb679ea)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
C4/Budgets.pm