From 4ebfb709f6cdeb263b579f7a3538c1a1342a939a Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 3 May 2016 11:03:52 +0100 Subject: [PATCH] Bug 16428: Use the biblio framework to know if a field is mapped MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The subroutine _build_default_values_for_mod_marc takes the frameworkcode in parameter, but ModItemFromMarc did not pass it. It uses it to know if a field is mapped or not to a Koha field (C4::Koha::IsKohaFieldLinked). Consequently the default framework ("") was always used. This bug has been found working on bug 13074 and has been put on a separate bug report to ease the backport. Test plan: Without this change, the tests added by bug 16428 won't pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 52b1b8eae1136af1e901560214a641494acaf577) Signed-off-by: Frédéric Demians --- C4/Items.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Items.pm b/C4/Items.pm index 6bb6e67151..8ee41691c0 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -510,7 +510,7 @@ sub ModItemFromMarc { my $localitemmarc = MARC::Record->new; $localitemmarc->append_fields( $item_marc->field($itemtag) ); my $item = &TransformMarcToKoha( $localitemmarc, $frameworkcode, 'items' ); - my $default_values = _build_default_values_for_mod_marc(); + my $default_values = _build_default_values_for_mod_marc($frameworkcode); foreach my $item_field ( keys %$default_values ) { $item->{$item_field} = $default_values->{$item_field} unless exists $item->{$item_field}; -- 2.39.5