]> git.koha-community.org Git - koha.git/commit
Bug 28409: Comprehensively validate category in opac-shelves.pl
authorDavid Cook <dcook@prosentient.com.au>
Fri, 21 May 2021 06:52:25 +0000 (06:52 +0000)
committerWainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
Mon, 21 Jun 2021 18:30:51 +0000 (18:30 +0000)
commitb2e542e783f6b9dea43d757a6b934880e2e44779
treef7dd14afac5996f146974c6a75fe78e7224afa93
parent0f3152920b7b2ff939413a7ab3652b17b10a724e
Bug 28409: Comprehensively validate category in opac-shelves.pl

Default to a category of 1 (ie Private). Only allow input of 1
or 2 (ie Public)

== Test plan ==
1. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?category=function(){window.location.href%20=%20%27https://git.koha-community.org/stats/koha-master/authors.html%27}()
2. Note that you are redirected to another website
3. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=add&shelfname=foo&category=9
4. Note that you can't see this list in the Lists (but it has been added to the database)
5. Apply the patch & restart services
6. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?category=function(){window.location.href%20=%20%27https://git.koha-community.org/stats/koha-master/authors.html%27}()
7. Note that you are not redirected to another website
8. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=add&shelfname=bar&category=9
9. Note that "bar" has been added as a Private list

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
(cherry picked from commit c75145e25ff3d171562e483c93aa3d452677f618)
Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
(cherry picked from commit c75145e25ff3d171562e483c93aa3d452677f618)
opac/opac-shelves.pl