From d63d0a6bb587401165097a9037b7a0bbab8e29c9 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 5 Jan 2016 10:49:31 +0000
Subject: [PATCH] Bug 15469: Fix authority header search
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Introduced by bug 15381.

The logs contain plenty of "detail.pl: No method value!" and the
dropwdown list is not correctly populated (no value for options)

Test plan:
Go to the authority module and have a look at the auth type codes
dropdown list.
Without this patch, the values of the options are empty.
With this patch, the values are correctly filled.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  I confirm this patch silence noise in log file.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
---
 .../prog/en/includes/authorities-search.inc          | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc
index 9be4ee0f55..164e20fc0c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc
@@ -27,9 +27,9 @@
         [% IF (marcflavour == 'UNIMARC' ) %]<option value="">All authority types</option>[% END %]
         [% FOREACH authority_type IN authority_types %]
             [% IF authority_type.authtypecode == authtypecode %]
-            <option value="[% authority_type.value %]" selected="selected">[% authority_type.authtypetext %]</option>
+            <option value="[% authority_type.authtypecode%]" selected="selected">[% authority_type.authtypetext %]</option>
             [% ELSE %]
-            <option value="[% authority_type.value %]">[% authority_type.authtypetext %]</option>
+            <option value="[% authority_type.authtypecode %]">[% authority_type.authtypetext %]</option>
             [% END %]
         [% END %]
         </select>
@@ -83,9 +83,9 @@
         [% IF (marcflavour == 'UNIMARC' ) %]<option value="">All authority types</option>[% END %]
         [% FOREACH authority_type IN authority_types %]
             [% IF authority_type.authtypecode == authtypecode %]
-            <option value="[% authority_type.value %]" selected="selected">[% authority_type.authtypetext %]</option>
+            <option value="[% authority_type.authtypecode %]" selected="selected">[% authority_type.authtypetext %]</option>
             [% ELSE %]
-            <option value="[% authority_type.value %]">[% authority_type.authtypetext %]</option>
+            <option value="[% authority_type.authtypecode %]">[% authority_type.authtypetext %]</option>
             [% END %]
         [% END %]
         </select>
@@ -139,9 +139,9 @@
         [% IF (marcflavour == 'UNIMARC' ) %]<option value="">All authority types</option>[% END %]
         [% FOREACH authority_type IN authority_types %]
             [% IF authority_type.authtypecode == authtypecode %]
-            <option value="[% authority_type.value %]" selected="selected">[% authority_type.authtypetext %]</option>
+            <option value="[% authority_type.authtypecode %]" selected="selected">[% authority_type.authtypetext %]</option>
             [% ELSE %]
-            <option value="[% authority_type.value %]">[% authority_type.authtypetext %]</option>
+            <option value="[% authority_type.authtypecode %]">[% authority_type.authtypetext %]</option>
             [% END %]
         [% END %]
         </select>
-- 
2.39.5