From 52135ea553c9fcf02cb41490a1a790f31ed7ed15 Mon Sep 17 00:00:00 2001 From: Eden Bacani Date: Tue, 19 Jan 2021 21:21:51 +0000 Subject: [PATCH] Bug 27395: Add a warning to PatronSelfRegistrationDefaultCategory This patch adds a warning to the PatronSelfRegistrationDefaultCategory system preference to not use a regular patron category for self registration. If a regular patron category code is used and the cleanup_database cronjob is setup to delete unverified and unfinished OPAC self registrations, it permanently and and unrecoverably deletes all patrons that have registered more than PatronSelfRegistrationExpireTemporaryAccountsDelay days ago. It also removes unnecessary apostrophes at the end of two self registration and modification system preference descriptions. Test plan: 1. Apply the patch. 2. Check that the warning message for the PatronSelfRegistrationDefaultCategory system preference is clear and makes sense. 3. Sign off! Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 065c955cc67b6f113c9fb5d5ed918ba1400b5af9) Signed-off-by: Fridolin Somers (cherry picked from commit aea5a5800a6a4aead6e8fa61fd8a12d2e9b5f1e4) Signed-off-by: Andrew Fuerste-Henry (cherry picked from commit c01dd7a8fb3cf82226a9ca525f49ad0d12e05d68) Signed-off-by: Victor Grousset/tuxayo --- .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 1 + 1 file changed, 1 insertion(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index 2a207645d3..956a05e807 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ -807,6 +807,7 @@ OPAC: - pref: PatronSelfRegistrationDefaultCategory class: short - "as the default patron category for patrons registered via the OPAC." + - "
WARNING: Do not use a regular patron category for self registration. If the misc/cronjobs/cleanup_database.pl cronjob is setup to delete unverified and unfinished OPAC self registrations, it will permanently and unrecoverably delete all patrons that have registered more than PatronSelfRegistrationExpireTemporaryAccountsDelay days ago." - - "Delete patrons still in the category indicated by PatronSelfRegistrationDefaultCategory" - pref: PatronSelfRegistrationExpireTemporaryAccountsDelay -- 2.39.5