]> git.koha-community.org Git - koha.git/commit
Bug 13806: Sanitize inputs where creating Reports subgroup
authorOwen Leonard <oleonard@myacpl.org>
Fri, 22 Nov 2019 16:47:45 +0000 (16:47 +0000)
committerHayley Mapley <hayleymapley@catalyst.net.nz>
Thu, 9 Jan 2020 22:23:10 +0000 (11:23 +1300)
commit616c113d788af6eaec732ab147710c5b14efd8b3
tree3e7a91a0e1efe5dc2b1feb150ddc23d238bbaca1
parent6572937d0806ed48d9cb69223a8196de8099193e
Bug 13806: Sanitize inputs where creating Reports subgroup

This patch adds validation of report group and subgroup inputs so that
the user can't enter data into only one half of the group code/name
pair.

To test, apply the patch and go to Reports -> Use saved.

  - Create or edit a report which doesn't have a group or subgroup
    assigned.

  - Under "Report group," select the "or create" radio button.

  - Click the "Update SQL" button to submit the form without entering a
    group code or name. The form should require taht you enter data into
    both fields.

  - Enter data into the report group code and name fields. Add data to
    either the code or data field under "Report subgroup." You should
    not be able to submit the form without populating both.

  - Start over editing a report which doesn't have a group or subgroup
    assigned.

    - Select an existing group under "Report group."

    - Under "Report subgroup," select the "or create" option.

      - You should not be able to submit the form without adding data in
        both the code and name fields for the report subgroup.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 798cc769fe25478ed41fa50cd41fd3a90c0a4a24)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 992cbe96e6b17853b369f719d40987bbb38bd64e)
Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt