]> git.koha-community.org Git - koha.git/commit
Bug 11184: correct attribute cloning for the patron editor
authorSrdjan <srdjan@catalyst.net.nz>
Fri, 1 Nov 2013 08:24:11 +0000 (21:24 +1300)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 13 Aug 2014 13:43:49 +0000 (09:43 -0400)
commit87c0b157f97cce9748ab095bbee0e32144424a89
tree5619e0e76bdd52eb2123cde0cfa903959e6ee6a6
parenta950cb6a6bfdb51d8892653ad101f82a30df9f2d
Bug 11184: correct attribute cloning for the patron editor

This patch fixes Perl warnings logged when setting up the
patron attribute form in the patron editor.

To test - Patron details entry page:
* Have  ExtendedPatronAttributes enabled. Check that "Additional
  attributes and identifiers" section behaves.
* Verify that editing and saving a patron record does not
  result in the following sorts of entries in the Apache log:

  se of uninitialized value $_ in hash element at memberentry.pl line 798
  Use of uninitialized value in anonymous hash ({}) at memberentry.pl line 798

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested with different types of patron attributes:
- repeatable
- linked to an authorized value
- free text
Tested editing, adding, removing one of multiple, adding multiple,
etc. No regressions found.
Passes all tests and QA script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 3334f03d779dc41bac3fe6e25a0d08733fc030ca)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 4bcb5a0d885a308ef9e0992706c5db2db720df7a)
members/memberentry.pl