From 56a4abf13f7598c8597d12ccb25c5abb547a998e Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 9 Dec 2015 10:24:15 +0000 Subject: [PATCH] Bug 14945: Add 2 more tests for StoreLastBorrower Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com --- .../Circulation/AnonymiseIssueHistory.t | 28 ++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Circulation/AnonymiseIssueHistory.t b/t/db_dependent/Circulation/AnonymiseIssueHistory.t index 87049ad7f5..5735f86eba 100644 --- a/t/db_dependent/Circulation/AnonymiseIssueHistory.t +++ b/t/db_dependent/Circulation/AnonymiseIssueHistory.t @@ -164,7 +164,7 @@ subtest 'AnonymousPatron is not defined' => sub { }; subtest 'Test StoreLastBorrower' => sub { - plan tests => 4; + plan tests => 6; t::lib::Mocks::mock_preference( 'StoreLastBorrower', '1' ); @@ -241,6 +241,32 @@ subtest 'Test StoreLastBorrower' => sub { my $patron_object2 = $item_object->last_returned_by(); is( $patron_object->id, $patron_object2->id, 'Calling last_returned_by with Borrower object sets last_returned_by to that borrower' ); + + $patron_object->delete; + $item_object = Koha::Items->find( $item->{itemnumber} ); + is( $item_object->last_returned_by, undef, 'last_returned_by should return undef if the last patron to return the item has been deleted' ); + + t::lib::Mocks::mock_preference( 'StoreLastBorrower', '0' ); + $patron = $builder->build( + { + source => 'Borrower', + value => { privacy => 1, } + } + ); + + $issue = $builder->build( + { + source => 'Issue', + value => { + borrowernumber => $patron->{borrowernumber}, + itemnumber => $item->{itemnumber}, + }, + } + ); + ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, undef, '2010-10-10' ); + + $item_object = Koha::Items->find( $item->{itemnumber} ); + is( $item_object->last_returned_by, undef, 'Last patron to return item should not be stored if StoreLastBorrower if off' ); }; $schema->storage->txn_rollback; -- 2.39.5