From a04e8a33904fc279be776d3db85db19b7cf6713d Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Sun, 22 Mar 2015 22:07:32 +0100 Subject: [PATCH] Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists For changing the sequence of patrons on a routing list by changing one of the numbers via the pull downs, full serial permission is needed: To test: - Give your patron full serial permissions - Create a subscription and a routing list for it - Change the sequence on the routing list using the pull downs - Verify this works - Remove any of the serial sub permissions (claim serials or similar) - Verify changing the sequence now results in a permission error - Apply patch - Verify that the permission error is gone now - Remove the routing permission - Verify the permission error is back (but this seems to make sense) In general more fixes would be required to make all routing related features depend on the routing permission, but I think this fixes the bug making it depend on the correct permission. Followed test plan. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 889e1953ec7fa07c4778918de9de8952c660d22e) Signed-off-by: Chris Cormack --- serials/reorder_members.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/serials/reorder_members.pl b/serials/reorder_members.pl index 8b64fc7723..531f8cb4ce 100755 --- a/serials/reorder_members.pl +++ b/serials/reorder_members.pl @@ -29,7 +29,7 @@ my $subscriptionid = $query->param('subscriptionid'); my $routingid = $query->param('routingid'); my $rank = $query->param('rank'); -checkauth( $query, 0, { serials => 1 }, 'intranet' ); +checkauth( $query, 0, { serials => 'routing' }, 'intranet' ); reorder_members( $subscriptionid, $routingid, $rank ); -- 2.39.5