]> git.koha-community.org Git - koha.git/commit
Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl
authorAleisha <aleishaamohia@hotmail.com>
Tue, 12 May 2015 03:30:46 +0000 (03:30 +0000)
committerMason James <mtj@kohaaloha.com>
Sat, 25 Jul 2015 04:21:16 +0000 (16:21 +1200)
commit5acd5c4a6ed9292be3faeda6f8e9beff3e299141
tree228ae9658d714307dc4d57e38e6bf9bf791f5765
parent148249423a1a88db52d0ba9d2fbb508a16869caf
Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl

This patch sets $reservedfor to an empty string.

Test plan
=========

1/ in a terminal, run `tail -f ` on your instance's opac-error.log
2/ go to the opac and search from an item that exists on the Koha
   instance.
3/ Select the title (if more than one title is returned) and click on
   'Place hold' link to go to opac-reserve.pl
4/ notice the warning - "opac-reserve.pl: Use of uninitialized value
   $reservedfor" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-reserve.pl)
7/ page works but the warning in step #4 is no longer thrown up
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: The QA test failed - "forbidden pattern: tab char (line 470)".

         Marking this as 'FAILED QA'

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
opac/opac-reserve.pl