]> git.koha-community.org Git - koha.git/commit
Bug 19003: Add a TestBuilder default for borrowers.login_attempts
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Sat, 29 Jul 2017 15:06:52 +0000 (17:06 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 29 Sep 2017 09:08:38 +0000 (11:08 +0200)
commit7f0612052770654aaa7d5344d18522dbfc8b9aab
tree2ffff9d9a5d6da5870e6806e8b16470e8b7ae4b0
parentd3e6a1a5fd9246811ef0036c6234c7a2cf11f7b3
Bug 19003: Add a TestBuilder default for borrowers.login_attempts

Bug 18314 causes t/db/SIP/Message.t to fail (quite often) since
TestBuilder fills login_attempts with a random number. (Note: Only
when FailedLoginAttempts is non-zero.)
Trivial fix: TestBuilder should have a zero default for login_attempts.

Test plan:
Do not yet apply this patch.
Set pref FailedLoginAttempts to say 3.
Run t/db_dependent/SIP/Message.t. Might fail on the password test (CQ).
Apply this patch.
Run t/db_dependent/SIP/Message.t again. Does not fail anymore.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 5bb56bf336187cde38e1a3b89c792ee6dc231acf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
t/lib/TestBuilder.pm