]> git.koha-community.org Git - koha.git/commit
Bug 30082: Bibliographic details tab missing when user can't add local cover image
authorOwen Leonard <oleonard@myacpl.org>
Fri, 11 Feb 2022 15:24:43 +0000 (15:24 +0000)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Mon, 21 Feb 2022 17:05:06 +0000 (17:05 +0000)
commitf23bcadb2fe670c00b40e6f545718066bd5dbe6a
tree87d6e249dec7952942818a066537063bb98ce8a7
parentb23a0f8a5f1b234e4f613b71bf3aba698cc52280
Bug 30082: Bibliographic details tab missing when user can't add local cover image

This patch corrects the template logic which determines whether the
"Images" tab should be displayed on the bibliographic detail page. The
"Images" tab should display whenever local cover images are enabled, not
just if the user has permission to manage cover images.

To test, apply the patch and go to Administration -> System preferences.

- Enable the LocalCoverImages system preference.
- Locate and view the detail page for a bibliographic record in the
  catalog which doesn't have a local cover image attached.

  - If you are logged in as a user with upload_local_cover_images
    permission you should see an "Images" tab with the message "No
    images have been uploaded for this bibliographic record yet" and an
    upload button.
  - If you are logged in as a user without upload_local_cover_images
    permission you should see an "Images" tab with just the "No
    images..." message.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 557bcbfa5240dd4b8fd4a32b7cde04183f86bc77)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt