From f41f4bb90c8e6af6b86a6c56e6311e6cf69cbfad Mon Sep 17 00:00:00 2001 From: =?utf8?q?Marc=20V=C3=A9ron?= Date: Tue, 18 Apr 2017 09:21:45 +0200 Subject: [PATCH] Bug 18443: Get rid of warning 'uninitialized value $user' in C4/Auth.pm When logging out from OPAC, plack-error.log log and/or opac-error.log complain about 'uninitialized value $user' in C4/Auth.pm line 187. The warning is not necessary, this patch removes it. To test: - try to trigger warning - apply patch - verify that warning no longer occurs - prove t/db_dependent/Auth.t - verifiy that SCO still behaves like before (especially if you break out from sco path) Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 7cbd9561271c1ac9ca3ccfd8ef257259a341f464) Signed-off-by: Katrin Fischer --- C4/Auth.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Auth.pm b/C4/Auth.pm index 051c8e46fe..2bfc851d7e 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -184,7 +184,7 @@ sub get_template_and_user { # If the user logged in is the SCO user and he tries to go out the SCO module, log the user out removing the CGISESSID cookie if ( $in->{type} eq 'opac' and $in->{template_name} !~ m|sco/| ) { - if ( C4::Context->preference('AutoSelfCheckID') && $user eq C4::Context->preference('AutoSelfCheckID') ) { + if ( $user && C4::Context->preference('AutoSelfCheckID') && $user eq C4::Context->preference('AutoSelfCheckID') ) { $template = C4::Templates::gettemplate( 'opac-auth.tt', 'opac', $in->{query} ); my $cookie = $in->{query}->cookie( -name => 'CGISESSID', -- 2.39.5