From d1e839d170c76f0d2a3869ba23ef38a1df239f9a Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Sun, 19 Mar 2023 22:06:12 +0000 Subject: [PATCH] Bug 33156: Fix JS error on batch patron modification The error currently breaks some of the functionality for updating patron attributes linked to AV values. With the bug, the input field will not change to the AV list when selected from the pull down of patron attributes. It was probably bug 29648 that changed the data structure without adapting for the additional data that is pushed to the object for the patron attribute columns. To test: * Create several extended patron attributes * Make sure at least one is linked to an AV * Repeatable and unique patron attributes can't be updated in batch patron modification, so you need some that can be modified. * Go to tools > batch patron modification * Enter one or more cardnumbers to update * Verify the table is missing columns, export and configure * Verify when selecting the AV tied patron attribute, the input remains a text one * Apply patch * Both should work now as expected Note: I believe there are some more errors on this page, but they should better be handled separately. So with this patch we push configuration again for each column to table columns, but the very last column keeps missing from the columns settings. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 7ca83d4b8c5581646af50d8378003b4233ad5fa2) Signed-off-by: Martin Renvoize (cherry picked from commit 1cd959c68b6e463fc504410919f009879e1e34f8) Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt index 4309ae87f7..26b4402c2d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt @@ -413,8 +413,9 @@ var patron_attributes_lib = new Array(); var patron_attributes_values = new Array(); var table_settings = [% TablesSettings.GetTableSettings( 'tools', 'batch_patron_modification', 'borrowerst', 'json' ) | $raw %]; + [% FOREACH attrh IN attributes_header %] - table_settings.push({ + table_settings["columns"].push({ columname: "[% attrh.attribute | html %]", cannot_be_modified: 0, cannot_be_toggled: 0, -- 2.39.5