From d30a8ac8171f27bd22c251281128ddf059016ab6 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 15 Aug 2019 13:46:35 +0000 Subject: [PATCH] Bug 23455: Patron card printing from Patron lists is broken This patch makes a few corrections to the process of printing patron cards from the patron lists page. These changes are necessitated by Bug 20650: Changes to the markup in patroncards/print.tt were not reflected in the JavaScript in patron_lists/lists.tt. Also fixed: A missing quotation mark, a missing semicolon, and incorrect template variable filter. To test, apply the patch and go to Tools -> Patron lists. - Click the "Actions" menu corresponding to a patron list. - Select "Print patron cards." - In the "Print patron cards" modal, click the "Export" button. - The modal should reload with a link to download a patron card PDF. The link should work correctly. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit a57aea15a7f86e71bdfb6d6540aed18b2702b226) Signed-off-by: Fridolin Somers (cherry picked from commit ca04ab8d7fb104961f1e299057ca02ef797aa20f) Signed-off-by: Lucas Gass --- .../intranet-tmpl/prog/en/modules/patron_lists/lists.tt | 6 +++--- .../intranet-tmpl/prog/en/modules/patroncards/print.tt | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt index 8e18d21ffd..6361ca7bf5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt @@ -47,7 +47,7 @@ [% IF l.shared %] [% IF shared_by_other %] - by [% INCLUDE 'patron-title.inc' patron=l.owner %] + by [% INCLUDE 'patron-title.inc' patron=l.owner %] [% ELSE %] by you [% END %] @@ -128,7 +128,7 @@