From c57368144fe79b5027af161393de8848822060be Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Mon, 15 Apr 2013 09:09:05 -0400
Subject: [PATCH] Bug 10054 - When SingleBranchMode is enabled, allow
 superlibrarians to set logged in library

Currently, when SingleBranchMode is enabled, nobody can change the
logged in library in Koha. To change it requires disable
SingleBranchMode, switching the library, and re-enabling it. It seems
reasonable to allow superlibrarians to switch the logged in library even
if SingleBranchMode is enabled.

Test Plan:
1) Apply this patch
3) Enable SingleBranchMode
4) Log in as a superlibrarian
5) Attempt to change the logged in branch
   This change should succeed
6) Log in as a non-superlibrarian account
7) Attempt to change the logged n branch
   This should not be allowed, as per Koha's current behavior

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I guess this doesn't do any harm even though the practical motivations
behind it, as described in the bug, seem otherwise solvable. If
SingleBranchMode is supposed to prevent librarians from switching their
logged in library why can they choose their library when they first log
in? Was SingleBranchMode supposed to only affect the OPAC originally? Or
should the login form be modified? This seems to be a band-aid on a
poorly-implemented feature.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch works as decribed. As this only adds a check for a superlibrarian
it seems safe and should not interfere with normal staff accounts.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(cherry picked from commit 218194fab0398e433651d5ba26634d79c63442f5)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
---
 .../intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt
index acad21c104..78ebd53881 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt
@@ -49,7 +49,7 @@ Updated:<ul>
 <fieldset class="rows">
     <legend>Set library</legend>
     <ol>
-    [% IF ( singleBranchMode ) %]
+    [% IF ( singleBranchMode && !CAN_user_superlibrarian ) %]
         <li>SingleBranchMode is ON.</li>
     [% ELSE %]
         <li><label for="branch">Choose library:</label>
-- 
2.39.5