]> git.koha-community.org Git - koha.git/commit
Bug 13201: GetSuggestion takes suggestionid
authorJonathan Druart <jonathan.druart@biblibre.com>
Wed, 5 Nov 2014 11:41:13 +0000 (12:41 +0100)
committerChris Cormack <chrisc@catalyst.net.nz>
Thu, 12 Feb 2015 22:40:13 +0000 (11:40 +1300)
commit073ac1abd26cf877f5a383197b38254d1be30ca5
tree975233eb2a65df304052d3d6bab50ab246641027
parent21d420b8810ac4ad3d33d0f678ea94109fa703e7
Bug 13201: GetSuggestion takes suggestionid

Having $ordernumber as the parameter in a function which is
handling suggestions and it is used as a suggestion id is
confusing to the coder and person trying to read the code.
This patch corrects the confusion.

REVISED TEST PLAN
-----------------
1) perldoc C4::Suggestions
   -- notice it says ordernumber for the GetSuggestions example.
2) Ensure you have CPL in your branches table.
3) prove -v t/db_dependent/Suggestions.t
   -- if you have more than 8 itemtypes in your database, two
      tests at the end will fail, but that is not relevant to
      the modified GetSuggestions code.
4) apply patch
5) perldoc C4::Suggestions
   -- notice it is corrected now.
6) prove -v t/db_dependent/Suggestions.t
   -- it should run with the same results as in step 3.
      That is, if you have 8 itemtypes, all pass, otherwise
      those two tests fail.
7) run koha qa test tool

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit ddf909ae24df5a3185370f5c4916135bb94b67ae)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
C4/Suggestions.pm