From 3b8ca43be9aeed02982170a58a62388bed220d80 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 21 Oct 2020 17:15:30 +0000 Subject: [PATCH] Bug 26766: Correct selection of title during OPAC note confirmation This patch modifies the JavaScript in opac-user.tt which executes when the user submits a checkout note. The script tries to grab the checkout's title from an earlier cell in the table row so that it can display it in the confirmation message. Before start ratings were enabled on this page, the title of each checked-out item was the only HTML inside this table cell, so it was necessary only to grab the HTML contents of the . Now that star ratings might be displayed as well we must make the selection more specific. To test, apply the patch and enable both the OpacStarRatings and AllowCheckoutNotes preferences. - Log in to the OPAC as a user with checkouts. - On the "Your summary" page, fill out and submit the "Note" field for one of your checkouts. - In the confirmation message, confirm that the correct title information is displayed as a link to the bibliographic detail page. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 54dcce14139bf5c60e98603a667629141296580e) Signed-off-by: Lucas Gass --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt index 143b11c464..9775a933cf 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ -909,7 +909,7 @@ $(".js_submitnote").click(function(e){ var $self = $(this); - var title = $(this).parent().siblings('.title').html(); + var title = $(this).parent().parent().find('a.title')[0].outerHTML; var $noteinput = $(this).siblings('input[name="note"]').first(); var ajaxData = { -- 2.39.5