From 726cfda78b24df8a87cf060455430c91cb41a930 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 14 Jan 2021 16:56:00 +0000 Subject: [PATCH] Bug 27437: Improve hint labels on library creation form This patch makes a few minor template changes to the form for creating and editing libraries: -
changed to
- References to system preferences are linked directly to that preference if the user has permission. - The MARC organization code label has been corrected so that it works now. To test, apply the patch and go to Administration -> Libraries -> New library. - Confirm that the hints for Ill staff email, Reply-to, Return-path, and MARC organization code look correct, including aligning with the input field above them. - Confirm that clicking the "MARC organization code" label moves focus to the correct field. - View the page as a user who both does and does not have permission to access system preferences, confirming that system preferences are linked correctly if the user has the correct permission. Signed-off-by: Mazen Khallaf Signed-off-by: Katrin Fischer JD Amended patch: Add missing space to correctly align input with label Signed-off-by: Jonathan Druart --- .../prog/en/modules/admin/branches.tt | 57 +++++++++++++++++-- 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt index 535d2e5c6b..cc640bb382 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt @@ -122,7 +122,7 @@ [% ELSE %] [% END %] - [% category.codedescription | html %] +
[% category.codedescription | html %]
[% END %] @@ -141,10 +141,40 @@
    • [% IF (Koha.Preference('ILLModule')) %] -

  • Default: ILLDefaultStaffEmail system preference
    • +
  • + + +
    + [% IF ( CAN_user_parameters_manage_sysprefs ) %] + Default: ILLDefaultStaffEmail system preference + [% ELSE %] + Default: ILLDefaultStaffEmail system preference + [% END %] +
    +
    • [% END %] -

  • Default: ReplyToDefault system preference
    • -

  • Default: ReturnpathDefault system preference
    • +
  • + + +
    + [% IF ( CAN_user_parameters_manage_sysprefs ) %] + Default: ReplyToDefault system preference + [% ELSE %] + Default: ReplyToDefault system preference + [% END %] +
    +
    • +
  • + + +
    + [% IF ( CAN_user_parameters_manage_sysprefs ) %] + Default: ReturnpathDefault system preference + [% ELSE %] + Default: ReturnpathDefault system preference + [% END %] +
    +
    • -
  • Can be entered as a single IP, or a subnet such as 192.168.1.*
    • -
  • If not filled in defaults to system preference MARCOrgCode. You can obtain your code from Library of Congress. +
  • + + +
    Can be entered as a single IP, or a subnet such as 192.168.1.*
    +
    • +
  • + + +
    + [% IF ( CAN_user_parameters_manage_sysprefs ) %] + If not filled in defaults to system preference MARCOrgCode. + [% ELSE %] + If not filled in defaults to system preference MARCOrgCode. + [% END %] + You can obtain your code from Library of Congress. +
    +