From f3890f6cb281e61d51c0712f10f9686e6c84556c Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 10 Mar 2023 16:14:50 +0000 Subject: [PATCH] Bug 33497: Add a filter relationship for branchtransfers This uses the new relationship from bug 33493 to fetch the transfers for items To test: 1 - Transfer some items on a bib 2 - View the biblio details page in the staff interface 3 - Apply patch 4 - Confirm the view is the same Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 2fe2a0aa03b40e143de551aaf9ee87edd592dc0f) Signed-off-by: Martin Renvoize --- Koha/Biblio.pm | 7 +++---- catalogue/detail.pl | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm index 05d8e7872e..43b53e17b0 100644 --- a/Koha/Biblio.pm +++ b/Koha/Biblio.pm @@ -494,11 +494,10 @@ sub items { return Koha::Items->_new_from_dbic( $items_rs ) unless $params->{host_items}; + my @itemnumbers = $items_rs->get_column('itemnumber')->all; my $host_itemnumbers = $self->_host_itemnumbers(); - my $search_params = { -or => [biblionumber => $self->id] }; - push @{$search_params->{'-or'}}, itemnumber => { -in => $host_itemnumbers } if $host_itemnumbers; - - return Koha::Items->search($search_params); + push @itemnumbers, @{ $host_itemnumbers }; + return Koha::Items->search({ "me.itemnumber" => { -in => \@itemnumbers } }); } =head3 host_items diff --git a/catalogue/detail.pl b/catalogue/detail.pl index f99afe40ad..31ebfc2743 100755 --- a/catalogue/detail.pl +++ b/catalogue/detail.pl @@ -193,7 +193,7 @@ my $itemtypes = { map { $_->itemtype => $_ } @{ Koha::ItemTypes->search_with_loc my $params; my $patron = Koha::Patrons->find( $borrowernumber ); $params->{ itemlost } = 0 if $patron->category->hidelostitems && !$showallitems; -my $items = $biblio->items({ host_items => 1 })->search_ordered( $params, { prefetch => ['issue','branchtransfers'] } ); +my $items = $biblio->items({ host_items => 1 })->search_ordered( $params, { prefetch => ['issue','branchtransfer'] } ); # flag indicating existence of at least one item linked via a host record my $hostrecords = $biblio->host_items->count; -- 2.39.5