From ad57d5f44c09ec8363b42145481a0457059faf36 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 5 Jul 2023 12:41:09 +0200 Subject: [PATCH] Bug 34184: Add empty option for suggestion "document type" Currently when editing a suggestion, the document type will preselect to the first entry as we don't have an empty entry. This can lead to data errors easily. Test plan: Create a new suggestion => Notice that "document type" is empty by default, pick one Edit it again => Notice that the value is kept and empty can be picked, pick empty Edit again => Empty is selected and saved in DB Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 6485f244e085fe48b796dd64178659c2f4a5e4ba) Signed-off-by: Martin Renvoize (cherry picked from commit cb07de6a981eab80c5764beb35c774e2910359ca) Signed-off-by: Matt Blenkinsop (cherry picked from commit 339e7adfbc8b450505f4db050932a876dff7c964) Signed-off-by: Lucas Gass --- .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index 9ec154bd9e..f993871af9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -391,7 +391,7 @@
  • - [% PROCESS 'av-build-dropbox.inc' name="itemtype", category="SUGGEST_FORMAT", size = 20, default=itemtype %] + [% PROCESS 'av-build-dropbox.inc' name="itemtype", category="SUGGEST_FORMAT", size=20, default=itemtype, empty=1 %]
    • [% IF patron_reason_loop %]
  • -- 2.39.5