From 68ede82a6522771cfc137a2163f37feaae81b93b Mon Sep 17 00:00:00 2001
From: Julian Maurice <julian.maurice@biblibre.com>
Date: Fri, 3 Feb 2023 11:58:55 +0100
Subject: [PATCH] Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0e85a35164e89287ee74e5ea99113a543a7c1dfc)
Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
---
 cataloguing/value_builder/unimarc_field_4XX.pl | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl
index 7b0ef28018..5130d26d90 100755
--- a/cataloguing/value_builder/unimarc_field_4XX.pl
+++ b/cataloguing/value_builder/unimarc_field_4XX.pl
@@ -46,9 +46,10 @@ sub plugin_javascript {
     my $function_name = $field_number;
     my $res           = "
     <script>
-        function Clic$function_name(i) {
-            defaultvalue=document.getElementById(\"$field_number\").value;
-            window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=\" + i + \"&result=\"+defaultvalue,\"unimarc_field_4\"+i+\"\",'width=900,height=700,toolbar=false,scrollbars=yes');
+        function Clic$function_name(event) {
+            event.preventDefault();
+            defaultvalue=document.getElementById(event.data.id).value;
+            window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_4\"+event.data.id+\"\",'width=900,height=700,toolbar=false,scrollbars=yes');
 
         }
     </script>
-- 
2.39.5