From e302db70b3fc6c6b68f291973a4743d084f77638 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 17 Jun 2021 16:02:35 -0300 Subject: [PATCH] Bug 28586: (follow-up) updated_by should be set This patch makes the route set the 'updated_by' attribute as well, when resolving a return claim through the API. Tests are added for this behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! updated_by is set correctly! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 343bf361e0417f10f79daff767c38c076d039b23) Signed-off-by: Fridolin Somers (cherry picked from commit ab02ae9c43dbbfda0bc977cbe952ebb01e0a0056) Signed-off-by: Victor Grousset/tuxayo (cherry picked from commit b6e26af2ec28a8b0435ba535ec38ba1528286aa6) Signed-off-by: Wainui Witika-Park (cherry picked from commit b6e26af2ec28a8b0435ba535ec38ba1528286aa6) --- Koha/REST/V1/ReturnClaims.pm | 1 + t/db_dependent/api/v1/return_claims.t | 10 ++++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Koha/REST/V1/ReturnClaims.pm b/Koha/REST/V1/ReturnClaims.pm index ce6b58ecef..857c0937c9 100644 --- a/Koha/REST/V1/ReturnClaims.pm +++ b/Koha/REST/V1/ReturnClaims.pm @@ -186,6 +186,7 @@ sub resolve_claim { resolution => $resolution, resolved_by => $resolved_by, resolved_on => \'NOW()', + updated_by => $resolved_by, } )->store; $claim->discard_changes; diff --git a/t/db_dependent/api/v1/return_claims.t b/t/db_dependent/api/v1/return_claims.t index 883fbd65c2..0ac7d8c969 100644 --- a/t/db_dependent/api/v1/return_claims.t +++ b/t/db_dependent/api/v1/return_claims.t @@ -175,7 +175,7 @@ subtest 'update_notes() tests' => sub { subtest 'resolve_claim() tests' => sub { - plan tests => 8; + plan tests => 9; $schema->storage->txn_begin; @@ -204,7 +204,12 @@ subtest 'resolve_claim() tests' => sub { my $claim_id = $claim->id; - $claim->created_by(undef)->store; # resolve the claim must work even if the created_by patron has been removed + $claim->set( + { + created_by => undef, + updated_by => undef, + } + )->store; # resolve the claim must work even if the created_by patron has been removed # Resolve a claim $t->put_ok( @@ -217,6 +222,7 @@ subtest 'resolve_claim() tests' => sub { $claim->discard_changes; is( $claim->resolution, "FOUNDINLIB" ); is( $claim->resolved_by, $librarian->id ); + is( $claim->updated_by, $librarian->id ); ok( $claim->resolved_on ); # Make sure the claim doesn't exist on the DB anymore -- 2.39.5