]> git.koha-community.org Git - koha.git/commit
Bug 25007: (follow-up) Fix the way image check alters layout
authorOwen Leonard <oleonard@myacpl.org>
Sat, 28 Mar 2020 17:42:50 +0000 (17:42 +0000)
committerJoy Nelson <joy@bywatersolutions.com>
Tue, 5 May 2020 22:44:14 +0000 (22:44 +0000)
commit05c4248721cfcbb9967b42e2bacf1a82eb845f1a
treead2052075305e825a72427b40aab5cdbfa7047c1
parent8c09c5ee80d59aae134454375f260c47a6af2f16
Bug 25007: (follow-up) Fix the way image check alters layout

A question in the bug report asks: Why is is necessary to change the
Bootstrap class to col-xs-12? The JavaScript which checks for the
existence of an Amazon cover image is designed to remove the Amazon
cover's container if there is none. Changing the class of
cover image column is gone.

However, the check is incorrect because it doesn't account for Local
Covers. There might be both a 1 x 1 pixel Amazon image and a local cover
image, so the layout shouldn't be changed unless there are no images
present.

To test, apply the patch and view the bibliographic details page of
various titles including:
- Amazon cover present, no local cover
- No Amazon cover, local cover image present
- Both Amazon and local cover image

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt