]> git.koha-community.org Git - koha.git/commit
Bug 12593: search facets die with regex error if biblio has square brackets in fields
authorDobrica Pavlinusic <dpavlin@rot13.org>
Thu, 17 Jul 2014 10:27:55 +0000 (12:27 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Tue, 23 Sep 2014 20:51:40 +0000 (20:51 +0000)
commit7f6f09da96002fbd5bd4a7cbecc532b28647ff27
treec5134ce2489fcf50f383fb5d4c28d3e1fdca410e
parenta67bce36b0c1eb79bb7fcd45ec6a7ec8e873522c
Bug 12593: search facets die with regex error if biblio has square brackets in fields

It's quite common to have [something] within facet data, and it produces following error:

Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE

This problem was intoduced in Bug 12151 but is trivial to fix.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Good catch.

To test:
- Created a bibliographic record, linked to an authority record (personal name). Did a search that returned the author as a facet.
- Added a [ symbol to the author name.
- Repeated the search
=> FAIL: "Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE"
- Apply the patch
- Retry the search
=> SUCCESS: No error, bracket shows correctly.

Passes koha-qa.pl too.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Search.pm