]> git.koha-community.org Git - koha.git/commit
Bug 16179: Do not crash if "rate me" is clicked and not rate selected
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 4 Apr 2016 13:45:48 +0000 (14:45 +0100)
committerFrédéric Demians <f.demians@tamil.fr>
Wed, 27 Apr 2016 15:02:34 +0000 (17:02 +0200)
commit029ccc0d512a767255807f21842262f8efcfcf17
tree561550b70ddee1e4c1a7290e2b6d9dbcac1f8b91
parent49e43878efa818fcf06b9f866102aa18c9a96e30
Bug 16179: Do not crash if "rate me" is clicked and not rate selected

If JS is disabled and a user clicks on the "Rate me" button, Koha will
crashes with:
DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null
at /usr/share/koha/lib/C4/Ratings.pm line 208

To avoid that, opac-ratings.pl will check if a rate has been selected.

Test plan:
Disable JS
On a record detail page, click on the "Rate me" button

TESTED PLAN:
1) go to /cgi-bin/koha/opac-ratings.pl?biblionumber=1
   -- kaboom as above.
2) apply patch
3) refresh
   -- either login screen (don't know why)
   -- or if already logged in, detail page.
4) koha qa test tool

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I tested successfully by temporarily removing the modification made by
Bug 16210.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
(cherry picked from commit b679cac96409b7248f8e224e10c73dafa4c82890)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit a965702c08f84d8d770fb81e09f13bee8e922bba)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
opac/opac-ratings.pl