]> git.koha-community.org Git - koha.git/commit
Bug 16179: Do not crash if "rate me" is clicked and not rate selected
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 4 Apr 2016 13:45:48 +0000 (14:45 +0100)
committerBrendan Gallagher <bredan@bywatersolutions.com>
Wed, 20 Apr 2016 19:50:00 +0000 (19:50 +0000)
commitb679cac96409b7248f8e224e10c73dafa4c82890
tree79ee93e7aff82725afb7d96117a7b91889e3bac5
parent08017f89f150394b6224fafb64fe8d12fc146ff1
Bug 16179: Do not crash if "rate me" is clicked and not rate selected

If JS is disabled and a user clicks on the "Rate me" button, Koha will
crashes with:
DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null
at /usr/share/koha/lib/C4/Ratings.pm line 208

To avoid that, opac-ratings.pl will check if a rate has been selected.

Test plan:
Disable JS
On a record detail page, click on the "Rate me" button

TESTED PLAN:
1) go to /cgi-bin/koha/opac-ratings.pl?biblionumber=1
   -- kaboom as above.
2) apply patch
3) refresh
   -- either login screen (don't know why)
   -- or if already logged in, detail page.
4) koha qa test tool

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I tested successfully by temporarily removing the modification made by
Bug 16210.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
opac/opac-ratings.pl