From 64460e4f4e01d8cb84a8037f444e5f7739a6bd40 Mon Sep 17 00:00:00 2001
From: Aleisha Amohia <aleishaamohia@hotmail.com>
Date: Mon, 23 Oct 2023 22:28:55 +0000
Subject: [PATCH] Bug 33164: Do not prevent processing of all error messages

This follow-up patch removes the use of $exit_required_p completely. The sysprefs BlockReturnOfLostItems and BlockReturnOfWithdrawnItems are handled in other scripts, and should not prevent the processing of all returns error messages when enabled.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 circ/returns.pl | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/circ/returns.pl b/circ/returns.pl
index 1ab7015453..669a6ac724 100755
--- a/circ/returns.pl
+++ b/circ/returns.pl
@@ -659,7 +659,6 @@ if ( $messages->{TransferredRecall} ) {
 my @errmsgloop;
 foreach my $code ( keys %$messages ) {
     my %err;
-    my $exit_required_p = 0;
     if ( $code eq 'BadBarcode' ) {
         $err{badbarcode} = 1;
         $err{msg}        = $messages->{'BadBarcode'};
@@ -697,7 +696,6 @@ foreach my $code ( keys %$messages ) {
     }
     elsif ( $code eq 'withdrawn' ) {
         $err{withdrawn} = 1;
-        $exit_required_p = 1 if C4::Context->preference("BlockReturnOfWithdrawnItems");
     }
     elsif ( $code eq 'WrongTransfer' ) {
         ;    # FIXME... anything to do here?
@@ -753,7 +751,6 @@ foreach my $code ( keys %$messages ) {
     if (%err) {
         push( @errmsgloop, \%err );
     }
-    last if $exit_required_p;
 }
 $template->param( errmsgloop => \@errmsgloop );
 
-- 
2.39.5