From 6709813a022de5e2cc53730e0299259ed9dc53bd Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 15 Sep 2015 11:44:32 +0100 Subject: [PATCH] Bug 12311: Do not return a lost item if modified in a batch MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit If a item is lost and issued, and you modify it in a batch, the item will be marked as returned. It should only be returned if the item is marked as lost. Test plan: 1/ Check an item out and mark it as lost 2/ Edit it in a batch (tools/batchMod.pl) and edit a field (notes for instance) 3/ The item should still be issued to the patron 4/ Edit it in a batch and edit the lost value, marked it as not lost 5/ The item should still be issued to the patron 6/ Edit it in a batch and edit the lost value, marked it as lost 7/ The item should have been returned. Signed-off-by: Hector Castro Works as advertised. Just one comment, lost status can be changed only if you change default framework to another framework then edit the item. If you change it in Item menu at left side of screen this will remove the item from patron’s checkouts and patron charged for lost item. Signed-off-by: Katrin Fischer For testing purposes the lost item field can be set to visible in the framework used. That will allow changing it without returning it at the same time. The other option is using the longoverdues.pl script. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit ca268ad877a6712aa07cb7c873c918d6fdfac52d) Signed-off-by: Chris Cormack --- tools/batchMod.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/batchMod.pl b/tools/batchMod.pl index 4ed0f106f5..5108419935 100755 --- a/tools/batchMod.pl +++ b/tools/batchMod.pl @@ -198,7 +198,7 @@ if ($op eq "action") { if ( $modified ) { eval { if ( my $item = ModItemFromMarc( $localmarcitem, $itemdata->{biblionumber}, $itemnumber ) ) { - LostItem($itemnumber, 'MARK RETURNED') if $item->{itemlost}; + LostItem($itemnumber, 'MARK RETURNED') if $item->{itemlost} and not $itemdata->{itemlost}; } }; } -- 2.39.5