From 6d226640b1c9c6541ac2aed4180d5692ab14e2f1 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 16 May 2024 12:52:04 +0000 Subject: [PATCH] Bug 36872: Untranslatable strings in request.tt There are errors in the JavaScript in the holds template in the staff client which results in strings not being translatable. This patch corrects the errors. To test, apply the patch and run through the process of placing a hold on multiple items in the staff interface. - At the hold confirmation step, try to submit the form without selecting pickup locations for one or more titles. - You should get an alert, "Please make sure all selected titles have a pickup location set". - Uncheck the checkboxes next to each title you're placing a hold on. - Submit the form. You should get an error: "Please select at least one title". - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:1499 - You should see the string "Please make sure all selected titles have a pickup location set". Signed-off-by: Caroline Cyr La Rose Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer (cherry picked from commit 537c960777f94cf964c757ed2773f330612ae3c7) Signed-off-by: Fridolin Somers (cherry picked from commit 4a51f8ca4ae772d5b3f9f06605aa72980ef49a19) Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 57e20ab7e0..a1097e0109 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -1540,12 +1540,12 @@ } }); if ( pickup_not_set > 0 ) { - alert( _("Please make sure all selected titles have a pickup location set" + "\n") ); + alert( _("Please make sure all selected titles have a pickup location set") + "\n" ); return false; } } else { - alert( _("Please select at least one title" + "\n") ); + alert( _("Please select at least one title") + "\n" ); return false; } -- 2.39.5