From 3759380bf5414ab181ed467dff6f84406a9d7ca0 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Mon, 13 Apr 2020 11:38:28 +0000 Subject: [PATCH] Bug 25123: Count the current fine when reducing for maxFine If maxFine is set, we total the patrons outstanding fines when making an adjustment, however, we neglect to count the amount of a currently updating fine when doing so. To test: 1 - Set maxFine to 5 2 - Create an overdue amount of 4.99 for a patron 3 - Set an itemtype to have a fine of $.10 per day 4 - Checkout an item of that type to a patron and backdate the due date so it is overdue 5 - Run fines.pl with -v 6 - Note the fine is reduced from $.10 (or a multiple) to .01 7 - Run it again, a second cent is added 8 - Repeat and note it keeps happening until the amount of the fine is reached, exceeding the maxFine setting 9 - Apply patch 10 - Note the fine is now reduced to 0 and nothing is added to account Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson --- C4/Overdues.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/C4/Overdues.pm b/C4/Overdues.pm index 64046aee9e..e0cb17a3de 100644 --- a/C4/Overdues.pm +++ b/C4/Overdues.pm @@ -546,7 +546,6 @@ sub UpdateFine { } else { $accountline = $overdue; - next; } } $total_amount_other += $overdue->amountoutstanding; -- 2.39.5