From eeefd05eaaeedbac50b46124d0c4335c27d80fa0 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 28 Apr 2022 09:43:06 +0200 Subject: [PATCH] Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON RevertWaitingStatus has already removed the itemnumber from the hold, passing $itemnumber (from scanned item) should work, as it will reattach the hold to the item Test plan: 1 - Enable HoldsAutoFill 2 - Place a title level hold 3 - Check in an item and confirm hold 4 - Switch to another branch 5 - Checkin the item Without this patch you got Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1577. at /kohadevbox/koha/C4/Reserves.pm line 1576 With this patch applied the operation succeeds Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall (cherry picked from commit 73a2e3558944effbdb4a19e6c8a331679d41fcf8) Signed-off-by: Victor Grousset/tuxayo --- circ/returns.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/returns.pl b/circ/returns.pl index e456e531f2..13dade8f86 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -436,7 +436,7 @@ if ( $messages->{'ResFound'}) { my $biblio = $item->biblio; my $diffBranchSend = !$branchCheck ? $reserve->{branchcode} : undef; - ModReserveAffect( $reserve->{itemnumber}, $reserve->{borrowernumber}, $diffBranchSend, $reserve->{reserve_id}, $desk_id ); + ModReserveAffect( $itemnumber, $reserve->{borrowernumber}, $diffBranchSend, $reserve->{reserve_id}, $desk_id ); my ( $messages, $nextreservinfo ) = GetOtherReserves($reserve->{itemnumber}); $template->param( -- 2.39.5