]> git.koha-community.org Git - koha.git/commit
Bug 15375 - Translatability: Fix issues on OPAC page 'Placing a hold'
authorMarc Véron <veron@veron.ch>
Tue, 15 Dec 2015 10:21:08 +0000 (11:21 +0100)
committerFrédéric Demians <f.demians@tamil.fr>
Thu, 11 Feb 2016 19:10:23 +0000 (20:10 +0100)
commitb5cca12611e368463da1f58c13cf800e01eb63a3
tree614323bf874b5b41947ef56a51295be5c734d459
parentfffe15f7954476aacd8c951b662b82f9c3191102
Bug 15375 - Translatability: Fix issues on OPAC page 'Placing a hold'

Fix several issues with odd translations on opac-reserve.tt due to
string splitting by tags.
In addition, streamline messages to make them similar to the same
messages on the OPAC summary page (Bug 15374)

To test:
- Apply patch
- Log in to OPAC
  - with blocked /debarred user (with and without comment and date)
  - with user who has to much fines
  - with user who has his card marked as lost
  - with user with expired account
  - with user with uncertain address information
- Try to put holds
- Verify that message about why holds are not possible is correct
  and displays nicely and that links in messages work
- Carefully examine code
- Search for regressions

(Amended: stray i removed, test plan updated, removed account that
          is about to expire)

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
I am going to sign off on this because it works as it should and I think the problems I had in comment 8 are a separate bug.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit f0face38698b5c803604b37509edad98e2291bcd)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit dceb3ed02284270af12b711014d30555115403f8)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt