From 1097106719b4859a1c79c4d3ebd1084a6d71c583 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Sat, 30 Oct 2010 01:36:57 -0400 Subject: [PATCH] Fix for Bug 5136, Replace SQL with call to GetAuthorisedValues An embedded query in circulation.pl for BOR_NOTES authorized values can be replaced with a call to GetAuthorisedValues Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack (cherry picked from commit 82d2cf464be0439b9d52de1d951baa856a4e60a4) Signed-off-by: Chris Nighswonger --- circ/circulation.pl | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index 319e4f671c..539b88ca04 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -663,16 +663,8 @@ my ($picture, $dberror) = GetPatronImage($borrower->{'cardnumber'}); $template->param( picture => 1 ) if $picture; # get authorised values with type of BOR_NOTES -my $dbh = C4::Context->dbh; -my @canned_notes; -my $sth = $dbh->prepare('SELECT * FROM authorised_values WHERE category = "BOR_NOTES"'); -$sth->execute(); -while ( my $row = $sth->fetchrow_hashref() ) { - push @canned_notes, $row; -} -if ( scalar( @canned_notes ) ) { - $template->param( canned_bor_notes_loop => \@canned_notes ); -} + +my $canned_notes = GetAuthorisedValues("BOR_NOTES"); $template->param( debt_confirmed => $debt_confirmed, @@ -681,5 +673,6 @@ $template->param( AllowRenewalLimitOverride => C4::Context->preference("AllowRenewalLimitOverride"), dateformat => C4::Context->preference("dateformat"), DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(), + canned_bor_notes_loop => $canned_notes, ); output_html_with_http_headers $query, $cookie, $template->output; -- 2.39.5